[libc-commits] [PATCH] D109261: [libc] add atof, strtof and strtod

[Michael Jones via Phabricator via libc-commits]

michaelrj added inline comments.


================
Comment at: libc/test/src/__support/string_to_float_comparison_test.cpp:73
+    if (!(expectedFloatRaw == floatRaw)) {
+      if (expectedFloatRaw == floatRaw + 1 ||
+          expectedFloatRaw == floatRaw - 1) {
----------------
lntue wrote:
> Can these test re-use the testing infra from FPBits and ULP functions? 
I'll look into that for the future when I'm cleaning this test up for running on the bot, but for the moment this is more of a quick and dirty thing that I'm using as a manual test.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109261/new/

https://reviews.llvm.org/D109261