[libc-commits] [PATCH] D110454: [libc][NFC] Add supporting class for atof implementation

Michael Jones via Phabricator via libc-commits libc-commits at lists.llvm.org
Mon Oct 4 12:29:38 PDT 2021


michaelrj added inline comments.


================
Comment at: libc/src/__support/GenerateHPDConstants.py:1
+from math import *
+
----------------
sivachandra wrote:
> This file should go in https://github.com/llvm/llvm-project/tree/main/libc/utils/mathtools.
> 
> Also, please add a detailed doc comment about what this script is for.
I may have gone a bit overboard with this one, but I wanted to have a clear explanation of how and why this trick works. I can make it a bit shorter if you want.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110454/new/

https://reviews.llvm.org/D110454



More information about the libc-commits mailing list