[libc-commits] [PATCH] D110454: [libc][NFC] Add supporting class for atof implementation

[Siva Chandra via Phabricator via libc-commits]

sivachandra accepted this revision.
sivachandra added inline comments.
This revision is now accepted and ready to land.


================
Comment at: libc/src/__support/GenerateHPDConstants.py:1
+from math import *
+
----------------
This file should go in https://github.com/llvm/llvm-project/tree/main/libc/utils/mathtools.

Also, please add a detailed doc comment about what this script is for.


================
Comment at: libc/src/__support/high_precision_decimal.h:32
+  // than 5^i then it will add one fewer digit. There are only 60 entries since
+  // that's the max shift amount.
+  static constexpr LShiftTableEntry LEFT_SHIFT_DIGIT_TABLE[] = {
----------------
Add a note here that these constants were generated using the `<link/to/the/script/in/utils/mathtools/>`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110454/new/

https://reviews.llvm.org/D110454