[libc-commits] [PATCH] D114726: [libc] Fix bugs with negative and mixed normal/denormal inputs in hypot implementation.

[Michael Jones via Phabricator via libc-commits]

michaelrj added inline comments.


================
Comment at: libc/utils/MPFRWrapper/MPFRUtils.cpp:315-318
+    if (fputil::FPBits<T>(thisAsT).getUnbiasedExponent() == 0)
+      ++thisExponent;
+    if (fputil::FPBits<T>(input).getUnbiasedExponent() == 0)
+      ++inputExponent;
----------------
based on my testing, the tests still pass if you don't update this file, could you add something to explain these changes, and possibly split them off into their own patch?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114726/new/

https://reviews.llvm.org/D114726