[libc-commits] [PATCH] D114300: [libc] Make string entrypoints mutualy exclusive.

[Siva Chandra via Phabricator via libc-commits]

sivachandra marked an inline comment as done.
sivachandra added inline comments.


================
Comment at: libc/src/string/mempcpy.cpp:24
+  inline_memcpy(result, reinterpret_cast<const char *>(src), count);
+  return static_cast<void *>(result + count);
 }
----------------
gchatelet wrote:
> nit: Not strictly necessary since every pointer casts to `void*`
I tried to retain the original as much as possible. But, I changed according to your suggestion.


================
Comment at: libc/src/string/strcpy.cpp:30
   // break the sanitizers.
-  SANITIZER_MEMORY_INITIALIZED(result, size);
+  SANITIZER_MEMORY_INITIALIZED(dst, size);
 
----------------
gchatelet wrote:
> that would be `dest`
Thanks for catching this. But, I completely removed the sanitizer part now as we don't use `memcpy` anymore.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114300/new/

https://reviews.llvm.org/D114300