[libc-commits] [PATCH] D114302: [libc] apply new lint rules

[Tue Ly via Phabricator via libc-commits]

lntue added inline comments.


================
Comment at: libc/src/__support/CPP/TypeTraits.h:34
 template <typename T1, typename T2>
-static constexpr bool IsSameV = IsSame<T1, T2>::Value;
+static constexpr bool IS_SAME_V = IsSame<T1, T2>::VALUE;
 
----------------
If we are going to change these, I feel like changing to match std::is_same_v style for these templates would be more beneficial.


================
Comment at: libc/src/__support/detailed_powers_of_ten.h:34
 
-static const uint64_t DETAILED_POWERS_OF_TEN[696][2] = {
+static const uint64_t detailed_powers_of_ten[696][2] = {
     {0x1732C869CD60E453, 0xFA8FD5A0081C0288}, // 1e-348
----------------
Can this one be all CAPS?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114302/new/

https://reviews.llvm.org/D114302