[libc-commits] [PATCH] D114236: [libc] Fix 64-bit ARM support and header includes

[Siva Chandra via Phabricator via libc-commits]

sivachandra added a comment.

Thanks for catching the build problems with exhaustive tests. They have bit rotted a bit because we don't run them on any bot.



================
Comment at: libc/src/__support/FPUtil/PlatformDefs.h:18
 
-#if defined(_WIN32)
+#if defined(_WIN32) || defined(__arch64__)
 #define LONG_DOUBLE_IS_DOUBLE
----------------
kristof.beyls wrote:
> Apologies for the drive-by comment.
> I just noticed the spelling __arch64__. It looks like maybe this should be __aarch64__?
On aarch64, long doubles are not the 64-bit IEEE double precision numbers. So, this would be incorrect after the typo is fixed.


================
Comment at: libc/test/src/math/exhaustive/cosf_test.cpp:12
 #include "utils/MPFRWrapper/MPFRUtils.h"
+#include "utils/UnitTest/FPMatcher.h"
 #include <math.h>
----------------
You should not need these headers to be included at all.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114236/new/

https://reviews.llvm.org/D114236