[libc-commits] [libc] 67de95b - Revert "[libc][NFC][Obvious] Fix the benchmarks after the switch to llvm/third-party"

Mircea Trofin via libc-commits libc-commits at lists.llvm.org
Tue Nov 16 16:59:30 PST 2021


Author: Mircea Trofin
Date: 2021-11-16T16:59:14-08:00
New Revision: 67de95b8c9556a1c2e715a0b1d4cec709f37055f

URL: https://github.com/llvm/llvm-project/commit/67de95b8c9556a1c2e715a0b1d4cec709f37055f
DIFF: https://github.com/llvm/llvm-project/commit/67de95b8c9556a1c2e715a0b1d4cec709f37055f.diff

LOG: Revert "[libc][NFC][Obvious] Fix the benchmarks after the switch to llvm/third-party"

This reverts commit 39e9f5d3685f3cfca0df072928ad96d973704dff.

Reverting, as we needed to re-revert the benchmarks move because it was
causing a build failure in the Fuchsia bots due to the way they consume
libcxx's CMakeLists. I want to make sure I understand where the fix
should be for that. After that, I'll incorporate the change here in the
re-reland.

Added: 
    

Modified: 
    libc/benchmarks/LibcBenchmark.cpp

Removed: 
    


################################################################################
diff  --git a/libc/benchmarks/LibcBenchmark.cpp b/libc/benchmarks/LibcBenchmark.cpp
index 621e0468db68d..cef595d75e0d9 100644
--- a/libc/benchmarks/LibcBenchmark.cpp
+++ b/libc/benchmarks/LibcBenchmark.cpp
@@ -15,7 +15,7 @@ namespace libc_benchmarks {
 
 void checkRequirements() {
   const auto &CpuInfo = benchmark::CPUInfo::Get();
-  if (CpuInfo.scaling == benchmark::CPUInfo::ENABLED)
+  if (CpuInfo.scaling_enabled)
     report_fatal_error(
         "CPU scaling is enabled, the benchmark real time measurements may be "
         "noisy and will incur extra overhead.");


        


More information about the libc-commits mailing list