[libc-commits] [PATCH] D113710: [libc] add basic strtold implementation

[Michael Jones via Phabricator via libc-commits]

michaelrj added inline comments.


================
Comment at: libc/test/src/stdlib/strtold_test.cpp:25
+               const int expectedErrno64 = 0, const int expectedErrno80 = 0,
+               const int expectedErrno128 = 0) {
+    // expectedRawData64 is the expected long double result as a uint64_t,
----------------
sivachandra wrote:
> May be I am missing something but I don't seem to find tests with different 64-bit, 80-bit and 128-bit `errno`. If they are missing, can we add them?
I've added tests with different errno behavior for the different sizes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113710/new/

https://reviews.llvm.org/D113710