[libc-commits] [PATCH] D113946: [libc][clang-tidy] fix namespace check for externals

Michael Jones via Phabricator via libc-commits libc-commits at lists.llvm.org
Mon Nov 15 15:15:26 PST 2021


michaelrj created this revision.
michaelrj added reviewers: sivachandra, lntue.
Herald added subscribers: libc-commits, carlosgalvezp, ecnelises, tschuett, xazax.hun.
Herald added a project: libc-project.
michaelrj requested review of this revision.
Herald added a project: clang-tools-extra.
Herald added a subscriber: cfe-commits.

Up until now, all references to `errno` were marked with `NOLINT`, since
it was technically calling an external function. This fixes the lint
rules so that `errno`, as well as `malloc`, `calloc`, `realloc`, and
`free` are all allowed to be called as external functions. All of the
relevant `NOLINT` comments have been removed, and the documentation has
been updated.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D113946

Files:
  clang-tools-extra/clang-tidy/llvmlibc/CalleeNamespaceCheck.cpp
  libc/docs/clang_tidy_checks.rst
  libc/src/__support/FPUtil/NearestIntegerOperations.h
  libc/src/__support/str_to_float.h
  libc/src/__support/str_to_integer.h
  libc/src/math/generic/math_utils.h
  libc/src/string/strdup.cpp
  libc/src/string/strndup.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D113946.387418.patch
Type: text/x-patch
Size: 7437 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libc-commits/attachments/20211115/e525c8c4/attachment.bin>


More information about the libc-commits mailing list