[libc-commits] [PATCH] D113710: [libc] add basic strtold implementation

[Siva Chandra via Phabricator via libc-commits]

sivachandra accepted this revision.
sivachandra added inline comments.


================
Comment at: libc/src/__support/str_to_float.h:91
+template <class T>
+inline void setSpecialLongDoubleIntBit(fputil::FPBits<T> *result) {
+  return;
----------------
User reference arguments. Also, the name of this function should probably be `setImplicitBit` so that it is easy to explain/understand the NOP nature for IEEE-754 encodings.


================
Comment at: libc/test/src/stdlib/strtold_test.cpp:25
+               const int expectedErrno64 = 0, const int expectedErrno80 = 0,
+               const int expectedErrno128 = 0) {
+    // expectedRawData64 is the expected long double result as a uint64_t,
----------------
May be I am missing something but I don't seem to find tests with different 64-bit, 80-bit and 128-bit `errno`. If they are missing, can we add them?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113710/new/

https://reviews.llvm.org/D113710