[libc-commits] [libc] 4cdf988 - [libc] tweak strtof errno behavior

[Michael Jones via libc-commits]

Author: Michael Jones
Date: 2021-11-11T10:17:38-08:00
New Revision: 4cdf9884b60de758243c85a6ac1f94aa975fd10d

URL: https://github.com/llvm/llvm-project/commit/4cdf9884b60de758243c85a6ac1f94aa975fd10d
DIFF: https://github.com/llvm/llvm-project/commit/4cdf9884b60de758243c85a6ac1f94aa975fd10d.diff

LOG: [libc] tweak strtof errno behavior

When strtof/d/ld return a subnormal number they may set errno to
ERANGE. This change makes this behavior more consistent by making any
decimal number converting to a subnormal set errno to ERANGE. This
brings it in line with hexadecimals, which currently only set errno to
ERANGE if the number is truncated when converting to a subnormal.

Reviewed By: sivachandra, lntue

Differential Revision: https://reviews.llvm.org/D113626

Added: 
    

Modified: 
    libc/src/__support/str_to_float.h
    libc/test/src/__support/str_to_float_test.cpp
    libc/test/src/stdlib/strtof_test.cpp

Removed: 
    


################################################################################
diff  --git a/libc/src/__support/str_to_float.h b/libc/src/__support/str_to_float.h
index 90408e77b557d..a768889f74f95 100644
--- a/libc/src/__support/str_to_float.h
+++ b/libc/src/__support/str_to_float.h
@@ -308,6 +308,10 @@ simpleDecimalConversion(const char *__restrict numStart,
     ++exp2;
   }
 
+  if (exp2 == 0) {
+    errno = ERANGE; // NOLINT
+  }
+
   *outputMantissa = finalMantissa;
   *outputExp2 = exp2;
 }

diff  --git a/libc/test/src/__support/str_to_float_test.cpp b/libc/test/src/__support/str_to_float_test.cpp
index 0fbc7c34148f2..0acb40e273f44 100644
--- a/libc/test/src/__support/str_to_float_test.cpp
+++ b/libc/test/src/__support/str_to_float_test.cpp
@@ -206,8 +206,8 @@ TEST_F(LlvmLibcStrToFloatTest, SimpleDecimalConversion64BasicExponents) {
 }
 
 TEST_F(LlvmLibcStrToFloatTest, SimpleDecimalConversion64BasicSubnormals) {
-  SimpleDecimalConversionTest<double>("1e-320", 0x7e8, 0);
-  SimpleDecimalConversionTest<double>("1e-308", 0x730d67819e8d2, 0);
+  SimpleDecimalConversionTest<double>("1e-320", 0x7e8, 0, ERANGE);
+  SimpleDecimalConversionTest<double>("1e-308", 0x730d67819e8d2, 0, ERANGE);
   SimpleDecimalConversionTest<double>("2.9e-308", 0x14da6df5e4bcc8, 1);
 }
 
@@ -217,7 +217,7 @@ TEST_F(LlvmLibcStrToFloatTest, SimpleDecimalConversion64SubnormalRounding) {
   // but this is the shortest string that results in the maximum subnormal that
   // I found.
   SimpleDecimalConversionTest<double>("2.225073858507201e-308", 0xfffffffffffff,
-                                      0);
+                                      0, ERANGE);
 
   // Same here, if you were to extend the max subnormal out for another 800
   // digits, incrementing any one of those digits would create a normal number.
@@ -227,7 +227,8 @@ TEST_F(LlvmLibcStrToFloatTest, SimpleDecimalConversion64SubnormalRounding) {
 
 TEST_F(LlvmLibcStrToFloatTest, SimpleDecimalConversion32SpecificFailures) {
   SimpleDecimalConversionTest<float>(
-      "1.4012984643248170709237295832899161312802619418765e-45", 0x1, 0);
+      "1.4012984643248170709237295832899161312802619418765e-45", 0x1, 0,
+      ERANGE);
 }
 
 TEST(LlvmLibcStrToFloatTest, SimpleDecimalConversionExtraTypes) {

diff  --git a/libc/test/src/stdlib/strtof_test.cpp b/libc/test/src/stdlib/strtof_test.cpp
index 2109e7d19df69..664133c1991fc 100644
--- a/libc/test/src/stdlib/strtof_test.cpp
+++ b/libc/test/src/stdlib/strtof_test.cpp
@@ -82,7 +82,8 @@ TEST_F(LlvmLibcStrToFTest, DecimalsWithRoundingProblems) {
 }
 
 TEST_F(LlvmLibcStrToFTest, DecimalSubnormals) {
-  runTest("1.4012984643248170709237295832899161312802619418765e-45", 55, 0x1);
+  runTest("1.4012984643248170709237295832899161312802619418765e-45", 55, 0x1,
+          ERANGE);
 }
 
 TEST_F(LlvmLibcStrToFTest, DecimalWithLongExponent) {