[libc-commits] [PATCH] D113097: [libc][NFC] Allow memcpy to be inlined

[Siva Chandra via Phabricator via libc-commits]

sivachandra added a comment.

Any reason why you have chosen `.inl` suffix instead of treating them as normal header files? IDEs and other tools are //used// to `.h` files (for example Phabricator's UI does not do syntax highlighting).



================
Comment at: libc/src/string/memory_utils/memcpy_implementations.inl:37
+
+static inline void inlined_memcpy(char *__restrict dst,
+                                  const char *__restrict src, size_t count) {
----------------
Nit and a question: Why give it an `inlined_` prefix which kind of implies that there is a non-inlined version somewhere? May be call it `memcpy_impl`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113097/new/

https://reviews.llvm.org/D113097