[libc-commits] [PATCH] D112720: [clang-tidy] Use globs in HeaderFilter
Carlos Galvez via Phabricator via libc-commits
libc-commits at lists.llvm.org
Mon Nov 1 00:55:22 PDT 2021
carlosgalvezp added a comment.
So after some thoughts, I came up with the following plan:
- This patch adds: `HeaderFilter`, `HeaderFilterMode`. `HeaderFilter` is intended to replace `HeaderFilterRegex` and we inform that `HeaderFilterRegex` is deprecated and will be removed in 2 releases. However during the transition period, both `HeaderFilter` and `HeaderFilterRegex` are accepted. `HeaderFilterMode` can take values: `regex` (default) or `glob`, and describes the behavior of `HeaderFilter` or `HeaderFilterRegex`. This allows people to use globs, while not breaking existing functionality.
- After 2 releases, we remove `HeaderFilterRegex` and set `HeaderFilterMode` as default to `glob`. We communicate that `HeaderFilterMode` is deprecated and will be removed in 2 releases.
- After (another) 2 releases, we remove `HeaderFilterMode`. The result is then what this patch looks like it is right now. Do we need to wait 2 more releases to remove `HeaderFilterMode` or can we do it already in the above step?
Does that sound good? Looking forward to your feedback.
CHANGES SINCE LAST ACTION
More information about the libc-commits