[libc-commits] [PATCH] D101895: [libc] Simplifies multi implementations
Andre Vieira via Phabricator via libc-commits
libc-commits at lists.llvm.org
Thu May 6 06:34:00 PDT 2021
avieira added inline comments.
Comment at: libc/src/string/CMakeLists.txt:234
+ COMPILE_OPTIONS "-mllvm --tail-merge-threshold=0")
+ add_memcpy(memcpy COMPILE_OPTIONS "-mllvm --tail-merge-threshold=0")
During some of my experiments I learned that CMAKE prefers if you pass such options with "SHELL:-mllvm --tail-mege-threshold=0" just in case there is another '-mllvm opt' or '-A B' like option.
Having said this, I am not seeing (with either SHELL or not) this option being passed when I do `ninja libc-benchmark-main -v -v', but don't quote me on this just yet, I might need to update all the patches you've put up for review.
Any chance you can verify you are seeing the same on your side?
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the libc-commits