[libc-commits] [libc] 0e97e84 - [libc] warns about missing linting only in full build mode

[Guillaume Chatelet via libc-commits]

Author: Guillaume Chatelet
Date: 2021-05-03T08:39:26Z
New Revision: 0e97e84a6588ca21d93037969c24c82f19698986

URL: https://github.com/llvm/llvm-project/commit/0e97e84a6588ca21d93037969c24c82f19698986
DIFF: https://github.com/llvm/llvm-project/commit/0e97e84a6588ca21d93037969c24c82f19698986.diff

LOG: [libc] warns about missing linting only in full build mode

Differential Revision: https://reviews.llvm.org/D101609

Added: 
    

Modified: 
    libc/CMakeLists.txt

Removed: 
    


################################################################################
diff  --git a/libc/CMakeLists.txt b/libc/CMakeLists.txt
index 61cc5a17a205b..ff1a0c6fe69a2 100644
--- a/libc/CMakeLists.txt
+++ b/libc/CMakeLists.txt
@@ -42,7 +42,12 @@ else()
                   --print-resource-dir not supported by host compiler")
 endif()
 
+option(LLVM_LIBC_FULL_BUILD "Build and test LLVM libc as if it is the full libc" OFF)
+
 option(LLVM_LIBC_ENABLE_LINTING "Enables linting of libc source files" OFF)
+if(LLVM_LIBC_ENABLE_LINTING AND (NOT LLVM_LIBC_FULL_BUILD))
+  message(FATAL_ERROR "Cannot enable linting when full libc build is not enabled.")
+endif()
 if(LLVM_LIBC_ENABLE_LINTING)
   if("clang-tools-extra" IN_LIST LLVM_ENABLE_PROJECTS
              AND "clang" IN_LIST LLVM_ENABLE_PROJECTS)
@@ -56,7 +61,7 @@ if(LLVM_LIBC_ENABLE_LINTING)
       To disable linting set LLVM_LIBC_ENABLE_LINTING to OFF
       (pass -DLLVM_LIBC_ENABLE_LINTING=OFF to cmake).")
   endif()
-else()
+elseif(LLVM_LIBC_FULL_BUILD)
   message(WARNING "
     Linting for libc is currently disabled.
 
@@ -64,8 +69,6 @@ else()
     (pass -DLLVM_LIBC_ENABLE_LINTING=ON to cmake).")
 endif()
 
-option(LLVM_LIBC_FULL_BUILD "Build and test LLVM libc as if it is the full libc" OFF)
-
 include(CMakeParseArguments)
 include(LLVMLibCRules)
 include(LLVMLibCCheckCpuFeatures)