[libc-commits] [PATCH] D105231: [libc] Add minimal Windows config

[Arthur Eubanks via Phabricator via libc-commits]

aeubanks added inline comments.


================
Comment at: libc/config/windows/README.md:33
+
+## Building Clang
+
----------------
I don't think we need to tell people how to build their own clang, we can tell them to get a recent clang somehow, either by downloading from https://releases.llvm.org/download.html or by building themselves (point to building clang documentation).


================
Comment at: libc/config/windows/entrypoints.txt:18-19
+    libc.src.ctype.tolower
+    libc.src.ctype.toupper
+ 
+    # string.h entrypoints
----------------
do you know what character is on this newline? there's an orange exclamation mark that I haven't seen before that probably shouldn't be there. Maybe a `\r`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105231/new/

https://reviews.llvm.org/D105231