[libc-commits] [PATCH] D105153: [libc] Add on float properties for precision floating point numbers in FloatProperties.h

[Siva Chandra via Phabricator via libc-commits]

sivachandra added a comment.

In D105153#2848520 <https://reviews.llvm.org/D105153#2848520>, @aeubanks wrote:

> @sivachandra why is the mantissa/exponent bits info duplicated between FloatProperties.h and FPBits.h in separate structs?

Once we moved to packed structs, we considered `FloatProperties.h` to be deprecated. There are only a handful of files where `FloatProperties.h` is included and so we were in the process of removing it. But, now that we want to resurrect this header file, we should scrub out the listings in `FPBits.h` and replace all uses with values defined in `FloatProperties.h`.

In D105153#2848573 <https://reviews.llvm.org/D105153#2848573>, @aeubanks wrote:

> @sivachandra are there existing tests for this sort of stuff?

The way I see it, this is the first patch in a series of at least two patches. As in, @hedingarcia should also prepare the follow up patch(es) which remove(s) the packed struct in `FPBits.h` and do all other related cleanups and updates. So, the changes in this patch will get tested in the follow up patch(es). This patch is essentially capturing specs so there is nothing to test.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105153/new/

https://reviews.llvm.org/D105153