[libc-commits] [PATCH] D105140: Modified and added floating properties to single, double, and quad precision floating point numbers.

[Arthur Eubanks via Phabricator via libc-commits]

aeubanks added a comment.

For the subject, make it imperative, not past tense, e.g. "Modify and add ...", and don't end with a period

The description shouldn't be a copy of the subject
It should probably explain the changes a bit more in detail and why you did it. e.g. why did you start using PlatformDefs.h?
Which float properties are you adding?

https://chris.beams.io/posts/git-commit/ is a good read

Phabricator/arcanist is a bit weird when changing commit messages, you have to do it locally (`git commit --amend`) and in `Edit Revision` on Phabricator


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105140/new/

https://reviews.llvm.org/D105140