[libc-commits] [PATCH] D104511: [libc] add benchmarks for memcmp and bzero

[Guillaume Chatelet via Phabricator via libc-commits]

gchatelet marked an inline comment as done.
gchatelet added inline comments.


================
Comment at: libc/benchmarks/LibcMemoryBenchmarkMain.cpp:131
+      : BufferA(BufferSize), BufferB(BufferSize) {
+    for (size_t I = 0; I < BufferSize; ++I) {
+      BufferA[I] = 0x7f;
----------------
courbet wrote:
> Can you please add a comment for why no `memset` for the casual reader ?
We can use `memset` actually (during benchmark the llvm-libc functions are only provided through the `__llvm_libc` namespace.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104511/new/

https://reviews.llvm.org/D104511