[libc-commits] [PATCH] D104511: [libc] add benchmarks for memcmp and bzero

[Clement Courbet via Phabricator via libc-commits]

courbet added inline comments.


================
Comment at: libc/benchmarks/LibcMemoryBenchmarkMain.cpp:131
+      : BufferA(BufferSize), BufferB(BufferSize) {
+    for (size_t I = 0; I < BufferSize; ++I) {
+      BufferA[I] = 0x7f;
----------------
Can you please add a comment for why no `memset` for the casual reader ?


================
Comment at: libc/src/string/CMakeLists.txt:306
+      -fno-builtin-memset
+      # -fno-builtin-memcmp
+    ${ARGN}
----------------
?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104511/new/

https://reviews.llvm.org/D104511