[libc-commits] [PATCH] D104226: [libc] Add a set of elementary operations
Clement Courbet via Phabricator via libc-commits
libc-commits at lists.llvm.org
Mon Jun 14 07:42:08 PDT 2021
courbet added inline comments.
================
Comment at: libc/src/string/memory_utils/elements.h:355
+#ifdef __clang__
+#if __has_builtin(__builtin_memcpy_inline)
+#define USE_BUILTIN_MEMCPY_INLINE
----------------
Do you really need to guard this with `#idef __clang__ ?`
================
Comment at: libc/src/string/memory_utils/elements.h:358
+#endif
+#elif defined(__GNUC__)
+#define USE_BUILTIN_MEMCPY
----------------
why not `#if __has_builtin(__builtin_memcpy)` ?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D104226/new/
https://reviews.llvm.org/D104226
More information about the libc-commits
mailing list