[libc-commits] [PATCH] D106919: [libc][wip] add integration tests for scudo in libc

[Siva Chandra via Phabricator via libc-commits]

sivachandra added inline comments.


================
Comment at: compiler-rt/lib/gwp_asan/CMakeLists.txt:81
 
+if(GWP_ASAN_BUILD_OBJECTS)
   add_compiler_rt_object_libraries(RTGwpAsan
----------------
If GWP-ASan is a standalone (as it does not depend on rest of compiler-rt), can we add the following object libraries unconditionally with `ARCHS ${ALL_GWP_ASAN_SUPPORTED_ARCH}`? Otherwise, there is again a disconnect between GWP-ASan build and libc build - GWP-ASan object libraries are condition to `GWP_ASAN_BUILD_OBJECTS`, which depends on `GWP_ASAN_SUPPORTED_ARCH`, which in turn depends on `COMPILER_RT_SUPPORTED_ARCH`. May be we can even add the above runtime libraries also unconditionally?



================
Comment at: compiler-rt/lib/scudo/standalone/CMakeLists.txt:171
+
+if(SCUDO_STANDALONE_BUILD_OBJECTS)
+  add_compiler_rt_object_libraries(RTScudoStandalone
----------------
A similar question for this as well.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106919/new/

https://reviews.llvm.org/D106919