[libc-commits] [PATCH] D105561: [libc] (WIP) Modify the struct that captures floating point encoding to have setters and getters

Hedin GarcĂ­a via Phabricator via libc-commits libc-commits at lists.llvm.org
Thu Jul 8 09:05:24 PDT 2021


hedingarcia updated this revision to Diff 357245.
hedingarcia added a comment.

Fixed error signaled when running the tests for LdExpTest.h by ensuring that the value passed to set mantissa 
did not lead to overload to the exponent value in FPBits.h and LongDoubleBitsX86.h.
Added asserts to detect those unintentional overflows in setMantissa() and setExponent().


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105561/new/

https://reviews.llvm.org/D105561

Files:
  libc/test/src/math/LdExpTest.h
  libc/test/src/math/NextAfterTest.h
  libc/test/src/math/RoundToIntegerTest.h
  libc/test/src/math/SqrtTest.h
  libc/utils/FPUtil/BasicOperations.h
  libc/utils/FPUtil/DivisionAndRemainderOperations.h
  libc/utils/FPUtil/FPBits.h
  libc/utils/FPUtil/Hypot.h
  libc/utils/FPUtil/LongDoubleBitsX86.h
  libc/utils/FPUtil/ManipulationFunctions.h
  libc/utils/FPUtil/NearestIntegerOperations.h
  libc/utils/FPUtil/NextAfterLongDoubleX86.h
  libc/utils/FPUtil/NormalFloat.h
  libc/utils/FPUtil/Sqrt.h
  libc/utils/FPUtil/SqrtLongDoubleX86.h
  libc/utils/FPUtil/TestHelpers.cpp
  libc/utils/FPUtil/generic/FMA.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D105561.357245.patch
Type: text/x-patch
Size: 42046 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libc-commits/attachments/20210708/0431d616/attachment-0001.bin>


More information about the libc-commits mailing list