[libc-commits] [PATCH] D107129: [libc] Move FPExceptMatcher out of TestHelpers.h

[Siva Chandra via Phabricator via libc-commits]

sivachandra created this revision.
sivachandra added a reviewer: michaelrj.
Herald added subscribers: libc-commits, ecnelises, tschuett, mgorny.
Herald added a project: libc-project.
sivachandra requested review of this revision.

TestHelpers.h pulls few pieces from LLVM libc's unittest framework
which aren't available on platforms like Fuchsia which use their own
unittest framework. So, by moving FPExceptMatcher to a different file
we can exclude LLVM libc specific pieces in a cleaner way.

In a later pass, it might make more sense to rename TestHelpers.h also
to FPMatcher.h. That way, we can make macros like EXPECT_FP_EQ to be
equivalent to EXPECT_EQ on platforms like Fuchsia.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D107129

Files:
  libc/test/src/fenv/enabled_exceptions_test.cpp
  libc/test/src/fenv/feholdexcept_test.cpp
  libc/utils/FPUtil/CMakeLists.txt
  libc/utils/FPUtil/FPExceptMatcher.cpp
  libc/utils/FPUtil/FPExceptMatcher.h
  libc/utils/FPUtil/TestHelpers.cpp
  libc/utils/FPUtil/TestHelpers.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D107129.362969.patch
Type: text/x-patch
Size: 8795 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libc-commits/attachments/20210730/fe6f64f0/attachment.bin>