[libc-commits] [PATCH] D106919: [libc][wip] add integration tests for scudo in libc
Siva Chandra via Phabricator via libc-commits
libc-commits at lists.llvm.org
Tue Jul 27 16:21:25 PDT 2021
sivachandra added inline comments.
================
Comment at: libc/lib/CMakeLists.txt:7
+if(COMPILER_RT_BUILD_GWP_ASAN)
+ list(APPEND SCUDO_DEPS RTGwpAsan.${LIBC_TARGET_ARCHITECTURE} RTGwpAsanBacktraceLibc.${LIBC_TARGET_ARCHITECTURE} RTGwpAsanSegvHandler.${LIBC_TARGET_ARCHITECTURE})
----------------
michaelrj wrote:
> sivachandra wrote:
> > hctim wrote:
> > > `COMPILER_RT_HAS_GWP_ASAN`
> > Should this be under `if(LLVM_LIBC_INCLUDE_SCUDO)`?
> I can't make this COMPILER_RT_HAS_GWP_ASAN since that variable won't be defined yet because the llvm libc cmake code runs before the compiler-rt cmake code does.
>
> If this was under `if(LLVM_LIBC_INCLUDE_SCUDO)` then you couldn't include GWP-ASan without also including SCUDO, and I figured it was better to give the user the option.
Is GWP-ASan useful without something like SCUDO calling into it?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D106919/new/
https://reviews.llvm.org/D106919
More information about the libc-commits
mailing list