[libc-commits] [PATCH] D106894: [libc] Enable MPFR library for math functions test

[Hedin García via Phabricator via libc-commits]

hedingarcia added inline comments.


================
Comment at: libc/config/windows/README.md:65
 
+    Alternatively: Because LLVM libc depends on the MPFR library to run the tests for its math functions, if built locally, its install path (e.g. `C:\src\install`) can be added as another flag option to this CMake command (-DLLVM_LIBC_MPFR_INSTALL_PATH=***PATH***).If this option is not used, Clang will look for the library on its default search directories.
+
----------------
sivachandra wrote:
> You don't have line breaks in this big chunk of text! I have a suggestion wrt the wording:
> 
> ```
> Some LLVM libc math unittests test correctness/accuracy against results from
> the [GNU MPFR library](https://www.mpfr.org/). If you want to run math tests
> which use MPFR, and if MPFR on your machine is not installed in the default
> include and linker lookup directories, then you can specify the MPFR install
> directory by passing an additional CMake option as follows:
> 
> -DLLVM_LIBC_MPFR_INSTALL_PATH=<path/mpfr/install/dir>
> 
> If the above option is specified, then `${LLVM_LIBC_MPFR_INSTALL_PATH}/include`
> will be added to the include directories, and
> `${LLVM_LIBC_MPFR_INSTALL_PATH}/lib` will be added to the linker lookup
> directories.
> 
> NOTE: The GNU MPFR library depends on the
> [GNU GMP library](https://gmplib.org/). If you specify the above option, then it
> will be assumed that GMP is also installed in the same directory or availabe in
> the default paths.
> ```
I agree, the message conveys more clearly the prerequisites for this CMake option.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106894/new/

https://reviews.llvm.org/D106894