[libc-commits] [PATCH] D106894: [libc] Enable MPFR library for math functions test

[Hedin García via Phabricator via libc-commits]

hedingarcia marked 3 inline comments as done.
hedingarcia added inline comments.


================
Comment at: libc/cmake/modules/LLVMLibCCheckMPFR.cmake:3
+if(LLVM_LIBC_MPFR_INSTALL_PATH)
+  set(LIBC_TESTS_CAN_USE_MPFR TRUE)
+else()
----------------
aeubanks wrote:
> just curious, what was the issue and fix to make `${LIBC_TESTS_CAN_USE_MPFR}` work?
The issue with it was that once set to true, if the path to MPFR was given, that value was not saved and evaluated False in libc/test/src/CMakeLists.txt and messages displayed that "WARNING: Math test...will be skipped as MPFR library is not available"; the test that needed MPFR did not ran. A way around it was to set it to the value in a cmake file separately and that variable will be carried to the subdirectorys utils and test. Hence carrying the True value in both the CMakeLists.txt in MPFRWrapper and on the one in test/src. Value was not being shared between two CMakeLists.txt siblings but they were passed from parent to child. 





Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106894/new/

https://reviews.llvm.org/D106894