[libc-commits] [PATCH] D106894: [libc] Enable MPFR library for math functions test

[Arthur Eubanks via Phabricator via libc-commits]

aeubanks added inline comments.


================
Comment at: libc/cmake/modules/LLVMLibCCheckMPFR.cmake:1
+set(LLVM_LIBC_MPFR_INSTALL_PATH "" CACHE PATH "Path to where MPFR was installed (e.g. C:/src/install or ~/src/install)")
+if(LLVM_LIBC_MPFR_INSTALL_PATH)
----------------
can you add an extra line after this?
and also at the very end of this file


================
Comment at: libc/cmake/modules/LLVMLibCCheckMPFR.cmake:3
+if(LLVM_LIBC_MPFR_INSTALL_PATH)
+  set(LIBC_TESTS_CAN_USE_MPFR TRUE)
+else()
----------------
just curious, what was the issue and fix to make `${LIBC_TESTS_CAN_USE_MPFR}` work?


================
Comment at: libc/utils/MPFRWrapper/CMakeLists.txt:13
 else()
-  message(WARNING "Math tests using MPFR will be skipped.")
+  essage(WARNING "Math tests using MPFR will be skipped.")
 endif()
----------------
`message`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106894/new/

https://reviews.llvm.org/D106894