[libc-commits] [PATCH] D106683: [libc] Accommodate Fuchsia's death test framework in fenv tests.
Michael Jones via Phabricator via libc-commits
libc-commits at lists.llvm.org
Fri Jul 23 13:48:21 PDT 2021
michaelrj accepted this revision.
michaelrj added a comment.
This revision is now accepted and ready to land.
LGTM with nit
================
Comment at: libc/test/src/fenv/feholdexcept_test.cpp:37
+ // run in a different thread. By setting the old environment inside
+ // the closure sets the environment for that different thread as well.
+ __llvm_libc::fputil::setEnv(&env);
----------------
You need an "it" between "closure" and "sets".
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D106683/new/
https://reviews.llvm.org/D106683
More information about the libc-commits
mailing list