[libc-commits] [PATCH] D106641: [libc] rewrite aarch64 memcmp	implementation
    Guillaume Chatelet via Phabricator via libc-commits 
    libc-commits at lists.llvm.org
       
    Fri Jul 23 02:33:55 PDT 2021
    
    
  
gchatelet added a comment.
@avieira I've rearranged the conditions so it's easier to understand (no `else` statements). I //think// the generated code is the same. Can you confirm that it performs the same?
================
Comment at: libc/src/string/aarch64/memcmp.cpp:43
+  // [64, 127]
+  return ThreeWayCompare<Skip<32>::Then<Loop<_16>>>(lhs, rhs, count);
 }
----------------
@avieira shouldn't this be `Skip<64>` instead of `Skip<32>` here?
Repository:
  rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106641/new/
https://reviews.llvm.org/D106641
    
    
More information about the libc-commits
mailing list