[libc-commits] [PATCH] D106502: [libc] add option to use SCUDO as the allocator

[Michael Jones via Phabricator via libc-commits]

michaelrj added inline comments.


================
Comment at: libc/CMakeLists.txt:76
 
+option(LLVM_LIBC_INCLUDE_SCUDO "Include the SCUDO standalone as the allocator for LLVM libc" OFF)
+if(LLVM_LIBC_INCLUDE_SCUDO)
----------------
sivachandra wrote:
> cheng.w wrote:
> > What about set this option `ON` by default?
> Not sure if `ON` or `OFF` is the correct default value while LLVM libc is not complete. When it is complete enough, I think default `ON` makes more sense. That said, if you have a reason to make it `ON` do share here.
I like `OFF` as a default value, so that if someone is trying to build LLVM libc for the first time they don't get unexpected errors due to not including `compiler-rt`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106502/new/

https://reviews.llvm.org/D106502