[libc-commits] [PATCH] D106502: [libc] add option to use SCUDO as the allocator

[Siva Chandra via Phabricator via libc-commits]

sivachandra added a comment.

As a follow up to this patch, we should add some kind of integration test to make sure that what is getting packaged is actually usable and works as expected.



================
Comment at: libc/cmake/modules/LLVMLibCLibraryRules.cmake:81
+  foreach(dep IN LISTS ENTRYPOINT_LIBRARY_EXT_DEPS)
+    list(APPEND objects $<TARGET_OBJECTS:${dep}>)
+  endforeach(dep)
----------------
Before we extract the objects from the `dep`, we should verify that the `dep` is an object library. Else, report a failure. One way could be to use the `TYPE` property to decide if the `dep` is an `OBJECT_LIBRARY`: https://cmake.org/cmake/help/v3.13/prop_tgt/TYPE.html

Most of this is already done in the code above from lines 65 to 78. So, we might just be able make use of the `DEPENDS` option with small adjustments.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106502/new/

https://reviews.llvm.org/D106502