[libc-commits] [PATCH] D105843: [libc] Add option to run specific tests

Arthur Eubanks via Phabricator via libc-commits libc-commits at lists.llvm.org
Wed Jul 21 13:47:45 PDT 2021


aeubanks added inline comments.


================
Comment at: libc/test/utils/UnitTest/testfilter_test.cpp:11-14
+#include "utils/testutils/ExecuteFunction.h"
+#include <cassert>
+#include <iostream>
+#include <string>
----------------
is all of this is no longer necessary?


================
Comment at: libc/utils/UnitTest/LibcTest.cpp:1
-//===-- Implementation of the base class for libc unittests ---------------===//
+///===-- Implementation of the base class for libc unittests---------------===//
 //
----------------
unintentional change?


================
Comment at: libc/utils/UnitTest/LibcTestMain.cpp:2
+//=== Main function for implementation of the base class for libc unittests
+//===//
+//
----------------
formatting


================
Comment at: libc/utils/UnitTest/LibcTestMain.cpp:12-15
+#include "utils/testutils/ExecuteFunction.h"
+#include <cassert>
+#include <iostream>
+#include <string>
----------------
ditto


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105843/new/

https://reviews.llvm.org/D105843



More information about the libc-commits mailing list