[libc-commits] [PATCH] D106391: [libc] Append math functions to Window's entrypoints

Siva Chandra via Phabricator via libc-commits libc-commits at lists.llvm.org
Wed Jul 21 01:21:51 PDT 2021


sivachandra accepted this revision.
sivachandra added inline comments.
This revision is now accepted and ready to land.


================
Comment at: libc/config/windows/entrypoints.txt:43
+
+set(TARGET_LIBM_ENTRYPOINTS
+    # math.h entrypoints
----------------
Not sure if libm makes sense on Windows. May be you can put all of these functions and the string functions under `TARGET_LLVMLIBC_ENTRYPOINTS` on line 71. We can revisit if required. OK for now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106391/new/

https://reviews.llvm.org/D106391



More information about the libc-commits mailing list