[libc-commits] [PATCH] D106386: [libc] Exclude few unused bits from x86 state for Windows

Arthur Eubanks via Phabricator via libc-commits libc-commits at lists.llvm.org
Tue Jul 20 12:17:25 PDT 2021


aeubanks added inline comments.


================
Comment at: libc/utils/FPUtil/x86_64/FEnv.h:94
   // TODO: Elaborate the remaining 20 bytes as required.
+  #if !(defined(_WIN32) || defined(_WIN64))
   uint32_t _[5];
----------------
according to https://docs.microsoft.com/en-us/cpp/preprocessor/predefined-macros, we don't need to check for `_WIN64`, `_WIN32` is enough

we should clean this up everywhere in libc


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106386/new/

https://reviews.llvm.org/D106386



More information about the libc-commits mailing list