[libc-commits] [PATCH] D105843: [libc] Add option to run specific tests

[Arthur Eubanks via Phabricator via libc-commits]

aeubanks added a comment.

the code looks good, but it'd be nice if we had tests for this



================
Comment at: libc/utils/UnitTest/LibcTest.cpp:179
+    std::cout << "Ran " << TestCount << " tests. "
+              << " PASS: " << TestCount - FailCount << ' '
+              << " FAIL: " << FailCount << '\n';
----------------
I think it'd be nice if we listed the number of skipped tests, or just the fact that there is a filter at all. But not necessary right now.


================
Comment at: libc/utils/UnitTest/LibcTest.cpp:371-372
+int main(int argc, char *argv[]) {
+  const char *TestFilter;
+  TestFilter = __llvm_libc::testing::getTestFilter(argc, argv);
+  return __llvm_libc::testing::Test::runTests(TestFilter);
----------------
merge these two into one line


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105843/new/

https://reviews.llvm.org/D105843