[libc-commits] [PATCH] D105843: [libc] Add option to run specific tests

[Siva Chandra via Phabricator via libc-commits]

sivachandra added a comment.

Sorry, another small nit.



================
Comment at: libc/utils/UnitTest/LibcTest.cpp:363
 
+const char * getTestFilter(int argc,char *argv[])  {
+  return argc > 1 ? argv[1] : NULL;
----------------
Can this function be static like this and avoid the public declaration as pointed out above:

```
static const char *getTestFileter(...) {
  ...
}
```


================
Comment at: libc/utils/UnitTest/LibcTest.h:59
 
+const char * getTestFilter(int, char *[]);
+
----------------
Do we need this declaration?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105843/new/

https://reviews.llvm.org/D105843