[libc-commits] [PATCH] D105843: [libc] Add option to run specific tests

Caitlyn Cano via Phabricator via libc-commits libc-commits at lists.llvm.org
Wed Jul 14 09:29:50 PDT 2021


caitlyncano added inline comments.


================
Comment at: libc/utils/UnitTest/LibcTest.cpp:184
+    std::cout << "No tests run.\n";
+    if(TestFilter)  {
+      std::cout << "No matching test for " << TestFilter << '\n';
----------------
sivachandra wrote:
> Please run clang-format for all patches touching c++ code. It will fix errors like this. Also, LLVM style says we shouldn't be using the curly brackets for single statement blocks unless the statement spans multiple lines. So, this if block does not need the curly brackets.
I ran clang format before this last upload, but it only caught some of the things so I'm just going to hand-fix the leftovers!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105843/new/

https://reviews.llvm.org/D105843



More information about the libc-commits mailing list