[libc-commits] [PATCH] D105561: [libc] Capture floating point encoding and arrange it sequentially in memory

[Arthur Eubanks via Phabricator via libc-commits]

aeubanks added a comment.

In D105561#2872173 <https://reviews.llvm.org/D105561#2872173>, @sivachandra wrote:

> In D105561#2872036 <https://reviews.llvm.org/D105561#2872036>, @aeubanks wrote:
>
>> lgtm besides the question for Siva of uint8_t vs bool for `getSign()`
>
> Logically, it doesn't matter. Are there benefits wrt compiler driven optimizations? If yes, then suggest the one which should be preferred?
>
> Otherwise, LGTM as well. Thanks for patiently resolving the comments.

Probably `bool` is better since the compiler can assume it's only 0 or 1.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105561/new/

https://reviews.llvm.org/D105561