[libc-commits] [PATCH] D105643: [libc] Don't pass -fpie/-ffreestanding on Windows

Arthur Eubanks via Phabricator via libc-commits libc-commits at lists.llvm.org
Thu Jul 8 15:31:44 PDT 2021


aeubanks added inline comments.


================
Comment at: libc/cmake/modules/LLVMLibCObjectRules.cmake:6
+  if(${LIBC_TARGET_OS} STREQUAL "windows")
+    set(${output_var} ${output_var} PARENT_SCOPE)
+  else()
----------------
we should skip this if block since it's not doing anything


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105643/new/

https://reviews.llvm.org/D105643



More information about the libc-commits mailing list