[libc-commits] [PATCH] D105643: [libc] Specificying compilation flags for Windows

[Arthur Eubanks via Phabricator via libc-commits]

aeubanks added a comment.

the commit title should be imperative, see https://chris.beams.io/posts/git-commit/ for good git commit tips

and I'd be clearer and say something like "Don't pass -fpie/-ffreestanding on Windows"



================
Comment at: libc/cmake/modules/LLVMLibCObjectRules.cmake:6
+  if(${LIBC_TARGET_OS} STREQUAL "windows")
+    set(${output_var} ${output_var} /Qfreestanding PARENT_SCOPE)
+  else()
----------------
actually I don't see this available in clang-cl or msvc, where did you find this?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105643/new/

https://reviews.llvm.org/D105643