[libc-commits] [PATCH] D105334: [libc] Make ULP error reflect the bit distance more closely.

[Tue Ly via Phabricator via libc-commits]

lntue accepted this revision.
lntue added inline comments.
This revision is now accepted and ready to land.


================
Comment at: libc/utils/MPFRWrapper/MPFRUtils.cpp:277
   //    should be good enough.
+  // 3. For close enough values, a ULP difference of N indicates a bit distance
+  //    of N between this number and [input].
----------------
I think we can specify exactly what is "close enough" in here, i.e. when the exponent difference is at most 1.
Also, we might need to add another remark here that currently the ULP function cannot distinguish +0.0 and -0.0 yet.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105334/new/

https://reviews.llvm.org/D105334