[libc-commits] [PATCH] D105231: [libc] Add minimal Windows config

[Arthur Eubanks via Phabricator via libc-commits]

aeubanks added a comment.

mostly lgtm, just a couple nits



================
Comment at: libc/config/windows/README.md:58
+
+9. Run the following CMake command to generate build files:
+
----------------
maybe it's good to explicitly state that libc needs to use the recently downloaded/built clang


================
Comment at: libc/config/windows/entrypoints.txt:18-19
+    libc.src.ctype.tolower
+    libc.src.ctype.toupper
+ 
+    # string.h entrypoints
----------------
aeubanks wrote:
> do you know what character is on this newline? there's an orange exclamation mark that I haven't seen before that probably shouldn't be there. Maybe a `\r`?
now the character has moved a couple lines above


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105231/new/

https://reviews.llvm.org/D105231