[libc-commits] [PATCH] D95650: [libc] small fixes to FEnv tests

[Siva Chandra via Phabricator via libc-commits]

sivachandra added inline comments.


================
Comment at: libc/test/src/fenv/enabled_exceptions_test.cpp:30
 
+  constexpr int allExcepts =
+      FE_DIVBYZERO | FE_INVALID | FE_INEXACT | FE_OVERFLOW | FE_UNDERFLOW;
----------------
Add a comment here, something like:

```
We '|' the individual exception flags instead of using FE_ALL_EXCEPT
as it can include non-standard extensions. Note that we should be able
to compile this file with headers from other libcs as well.
```


================
Comment at: libc/test/src/fenv/exception_status_test.cpp:110
   }
 
   int r = __llvm_libc::feraiseexcept(FE_ALL_EXCEPT);
----------------
You should be able to use `allExcepts` below instead of `FE_ALL_EXCEPT`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95650/new/

https://reviews.llvm.org/D95650