[libc-commits] [PATCH] D95205: [CMake][libc] Support cross-compiling libc-hdrgen

[Petr Hosek via Phabricator via libc-commits]

phosek added a comment.

In D95205#2521972 <https://reviews.llvm.org/D95205#2521972>, @sivachandra wrote:

> In D95205#2514656 <https://reviews.llvm.org/D95205#2514656>, @phosek wrote:
>
>> Note that there's one additional issue right now. The TableGen cross-compilation sub-invokes CMake which fails with:
>>
>>   CMake Error at /src/clang-llvm/llvm-project/libc/CMakeLists.txt:49 (message):
>>   
>>   
>>           'clang' and 'clang-tools-extra' are required in LLVM_ENABLE_PROJECTS to
>>           lint llvm-libc. The linting step performs important checks to help prevent
>>           the introduction of subtle bugs, but it may increase build times.
>>   
>>   
>>   
>>           To disable linting set LLVM_LIBC_ENABLE_LINTING to OFF
>>           (pass -DLLVM_LIBC_ENABLE_LINTING=OFF to cmake).
>>   
>>   
>>   -- Configuring incomplete, errors occurred!
>>
>> I think we'll need some way detect when we're cross-compiling TableGen and disable the linting support in that case.
>
> We can take simpler route of not enabling linting by default. Developer workflow will involve testing with linting enabled of course.

I'm fine with that, it'd also simplify integrating libc into the runtimes build where I'm also hitting this issue.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95205/new/

https://reviews.llvm.org/D95205