[libc-commits] [PATCH] D95006: [libc][NFC] add "LlvmLibc" as a prefix to all test names

Fangrui Song via Phabricator via libc-commits libc-commits at lists.llvm.org
Tue Jan 26 09:15:57 PST 2021


MaskRay added a comment.

In your commit the message has just `Reviewers:`. The `Reviewers:` list does not necessarily mean all the people on the list have acknowledged the patch so `Reviewers:` is mostly useless. Many people agree that both `Reviewed by:` & `Differential Revision:` should be present.

`arc amend` can fetch the Phabricator summary and amend the local description.

You can install `llvm/.git/hooks/pre-push` to prevent accidental `Summary:`, `Reviewers:`, `Subscribers:` and `Tags:`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95006/new/

https://reviews.llvm.org/D95006



More information about the libc-commits mailing list