[libc-commits] [PATCH] D94625: [libc][NFC] add macro for fuchsia to switch test backend to zxtest

[Siva Chandra via Phabricator via libc-commits]

sivachandra added inline comments.


================
Comment at: libc/utils/UnitTest/FuchsiaTest.h:1
+//===-- Header selector for libc unittests ----------------------*- C++ -*-===//
+//
----------------
I think this description is incorrect.


================
Comment at: libc/utils/UnitTest/FuchsiaTest.h:10
+#include <zxtest/zxtest.h>
+#ifdef isascii
+#undef isascii
----------------
Can you add comments here explaining why you need these?


================
Comment at: libc/utils/UnitTest/LibcTest.h:9
 
-#ifndef LLVM_LIBC_UTILS_UNITTEST_H
-#define LLVM_LIBC_UTILS_UNITTEST_H
+#ifndef LLVM_LIBC_UTILS_LIBCTEST_H
+#define LLVM_LIBC_UTILS_LIBCTEST_H
----------------
As the clang-tidy warning is saying, I think we should make it:

```
LLVM_LIBC_UTILS_UNITTEST_LIBCTEST_H
```

Same for other header files as well. It wasn't correct to begin with, so lets fix them as we are touching them.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94625/new/

https://reviews.llvm.org/D94625