[libc-commits] [PATCH] D94195: [libc] Switch to use a macro which does not insert a section for every libc function.

[Roland McGrath via Phabricator via libc-commits]

mcgrathr added inline comments.


================
Comment at: libc/src/__support/common.h.def:21
+  type name arglist; \
+  decltype(__llvm_libc::name) __##name##_impl__ __asm__(#name); \
+  decltype(__llvm_libc::name) name [[gnu::alias(#name)]]; \
----------------
In the Fuchsia build the public symbol also needs a `[[gnu::visibility("default")]]` attribute.
So I'd recommend adding a macro LLVM_LIBC_FUNCTION_ATTR with `#ifndef` define it to empty, then put that macro at the front of this line.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94195/new/

https://reviews.llvm.org/D94195