[libc-commits] [PATCH] D94018: [libc] Add implementation of fmaf.

[Tue Ly via Phabricator via libc-commits]

lntue marked 2 inline comments as done.
lntue added inline comments.


================
Comment at: libc/utils/MPFRWrapper/MPFRUtils.cpp:39
+template <typename T> struct Precision {
+  static constexpr unsigned int value = 128;
+};
----------------
sivachandra wrote:
> Is this used anywhere?
No it's not.  Removed the default value.


================
Comment at: libc/utils/MPFRWrapper/MPFRUtils.cpp:42
+
+template <> struct Precision<float> {
+  static constexpr unsigned int value = 24;
----------------
sivachandra wrote:
> Does it make sense to put these values in FPBits?
Yes, it should stay together with MantissaWidth and other constants  For now this is the only place using it so it does not matter much.  We can move it when cleaning up / consolidating FPBits infrastructures.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94018/new/

https://reviews.llvm.org/D94018